feat(core): report scenario override outcomes by 92Infinitus92 · Pull Request #6 · LimeChain/surfpool

92Infinitus92 · 2026-08-14T13:06:11Z

Return a typed outcome for every scenario override.
Report whether each override was applied or skipped, including the reason.
Add outcome-aware time travel for pending overrides.
Preserve RPC error classification and expose the new contract through the Node SDK.

Greptile Summary

The PR adds typed applied/skipped outcomes for scenario overrides and exposes them through scenario registration, time travel, and the Node SDK.

Stages override materialization and coordinates schedule updates across storage backends.
Returns outcome details while preserving RPC error classification.
Updates shared Rust contracts, endpoint metadata, generated TypeScript bindings, and integration coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
crates/core/src/surfnet/svm.rs	Implements outcome-aware scheduling, staged materialization, atomic persistent commits, replacement batching, and time-travel handling; previously reported failure paths are resolved or intentionally accepted.
crates/core/src/storage/mod.rs	Extends the storage contract with batch operations needed to coordinate scheduled override updates.
crates/core/src/storage/sqlite.rs	Implements transactional batch and cross-table operations for SQLite-backed schedules and account state.
crates/core/src/storage/postgres.rs	Implements transactional batch and cross-table operations for PostgreSQL-backed schedules and account state.
crates/core/src/rpc/surfnet_cheatcodes.rs	Changes scenario registration and time travel RPC responses to expose typed override outcomes.
crates/types/src/scenarios.rs	Defines the shared override outcome contract used by runtime and client surfaces.
crates/types/src/types.rs	Adds the outcome-aware time-travel response contract.
crates/sdk-node/surfpool-sdk/kit/types/api.ts	Updates the Node SDK cheatcode API to reflect the new scenario and time-travel response shapes.

Sequence Diagram

sequenceDiagram
    participant Client
    participant RPC
    participant SVM
    participant Schedule
    participant Accounts
    Client->>RPC: registerScenario / timeTravel
    RPC->>SVM: materialize scheduled overrides
    SVM->>Schedule: read target-slot batch
    SVM->>Accounts: stage account mutations
    SVM->>Schedule: atomically remove committed batch
    SVM-->>RPC: applied/skipped outcomes
    RPC-->>Client: typed outcome response

_{Reviews (14): Last reviewed commit: "refactor(rpc): return outcomes from time..." | Re-trigger Greptile}

Context used (5)

Knowledge Base — Scenario execution
Knowledge Base — Runtime storage
Knowledge Base — RPC service
Knowledge Base — Node.js SDK
Knowledge Base — Shared data contracts

greptile-apps

92Infinitus92 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

failfmi · 2026-08-17T11:17:02Z

@greptileai

92Infinitus92 · 2026-08-24T13:37:32Z

@greptileai

92Infinitus92 self-assigned this Aug 14, 2026

92Infinitus92 requested review from bakasura980 and failfmi August 14, 2026 13:06